[ 
https://issues.apache.org/jira/browse/ARTEMIS-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674881#comment-16674881
 ] 

ASF GitHub Bot commented on ARTEMIS-1710:
-----------------------------------------

Github user mtaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2414#discussion_r230684013
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
 ---
    @@ -1244,6 +1244,9 @@ private static PageSubscription 
locateSubscription(final long queueID,
              if (queueInfo != null) {
                 SimpleString address = queueInfo.getAddress();
                 PagingStore store = pagingManager.getPageStore(address);
    --- End diff --
    
    @wy96f I'm not following, that method is used purely for the File journal 
during replication.  The null check on paging store is due to, the additional 
bits in getPageStore(SimpleString storeName).
    
    ```java
          if (managementAddress != null && 
storeName.startsWith(managementAddress)) {
             return null;
          }
    ```


> Allow for management messages to exceed global-max-size limit
> -------------------------------------------------------------
>
>                 Key: ARTEMIS-1710
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1710
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Ulf Lilleengen
>            Assignee: Francesco Nigro
>            Priority: Major
>
> Use case: global-max-size is set to some limit to prevent the broker from 
> falling over. The broker is configured with N queues which are all blocked by 
> this limit.
> If this limit is reached, however, it is not possible to perform management 
> operations on the broker, so you're stuck.
>  
> It should be possible to have an address like 'activemq.management' bypass 
> this limit so that a broker can be recovered when the global-max-size is 
> reached.
>  
> To work around the problem, an external component needs to ensure that all 
> addresses created have a max-size-bytes set so that worst case, there is some 
> room left for 'activemq.management' address. In this case the broker 
> configuration needs to be known by the component creating addresses which is 
> impractical and it feels like this problem would be easier to solve inside 
> the broker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to