[ 
https://issues.apache.org/jira/browse/ARTEMIS-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709793#comment-16709793
 ] 

ASF GitHub Bot commented on ARTEMIS-2191:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2449
  
    @clebertsuconic No worries I can just wait to review the PR that you will 
send too, so we keep separate the changes.
    Or you are curious to see if it helps your part too? 


> Makes PostOfficeImpl::route common paths inlineable
> ---------------------------------------------------
>
>                 Key: ARTEMIS-2191
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2191
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.7.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> PostOfficeImpl::route is handling very difference cases (eg not 
> durable/durable messages, not durable/durable queues, transactions etc etc) 
> on the same code paths, making the code too big to be inlined when specific 
> code paths are needed.
> The code could be refactored to allow better inlining by using smaller 
> methods and moving away uncommon/slow path from the common one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to