[
https://issues.apache.org/jira/browse/ARTEMIS-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711434#comment-16711434
]
ASF GitHub Bot commented on ARTEMIS-2191:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2449
> It seems yours is a refactoring while mine had functionality involved..
hence I'm asking you to defer it
Yep, got it :+1:
> Adding your change in top of mine added failues (the one you sent).
I see 2 reasons for that:
- the context::clear that I have added is wrong
- there are other cases where we need to clear the context that are not
correct handled (due 2 my changes!)
-
> Makes PostOfficeImpl::route common paths inlineable
> ---------------------------------------------------
>
> Key: ARTEMIS-2191
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2191
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> PostOfficeImpl::route is handling very difference cases (eg not
> durable/durable messages, not durable/durable queues, transactions etc etc)
> on the same code paths, making the code too big to be inlined when specific
> code paths are needed.
> The code could be refactored to allow better inlining by using smaller
> methods and moving away uncommon/slow path from the common one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
