[
https://issues.apache.org/jira/browse/ARTEMIS-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728530#comment-16728530
]
ASF GitHub Bot commented on ARTEMIS-2212:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2480
> Whats the concurrent performance on this. Do you have some stats?
Only allocations profiles and given that is in the hot path, we have a LOT
of ConcurrentLinkedQueue::Node saved by this change.
The overall perf won't change by a bit (if not a tiny improvement), because
it isn't a bottleneck AFAIK.
> Re sync lock blocks. Could be replaced with lock on this and or sync
methods.
Agree at a first look, but I do not remember the reason why was used a
separate lock TBH
> Avoid using CLQ on ServerConsumerImpl
> -------------------------------------
>
> Key: ARTEMIS-2212
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2212
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> ServerConsumerImpl is using a ConcurrentLinkedQueue that can be avoided to be
> used considering that any accesses is guarded by a lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
