[
https://issues.apache.org/jira/browse/ARTEMIS-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738518#comment-16738518
]
ASF GitHub Bot commented on ARTEMIS-2212:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2480
@michaelandrepearce @clebertsuconic I have taken a better look to the code
and seems that `deliveringRefs` is being limited (if set) by both
`consumerWindowSize`and TCP-flow control hence I don't think is a big deal to
use an `ArrayDeque` in place of a `LinkedList`, but I can use too a collection
that get the bet of the both, a
[ChunkedQueue](https://github.com/franz1981/activemq-artemis/blob/40fb24898b5a89445fd3e2743d0f369548a37a17/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/ChunkedQueue.java)
that I have built some time ago. wdyt?
> Avoid using CLQ on ServerConsumerImpl
> -------------------------------------
>
> Key: ARTEMIS-2212
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2212
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
>
> ServerConsumerImpl is using a ConcurrentLinkedQueue that can be avoided to be
> used considering that any accesses is guarded by a lock.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
