[ 
https://issues.apache.org/jira/browse/ARTEMIS-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730609#comment-16730609
 ] 

ASF GitHub Bot commented on ARTEMIS-2215:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2483#discussion_r244470771
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
 ---
    @@ -461,8 +462,7 @@ void deleteLargeMessageFile(final LargeServerMessage 
largeServerMessage) throws
              try {
                 if (isReplicated() && replicator.isSynchronizing()) {
                    synchronized (largeMessagesToDelete) {
    --- End diff --
    
    If it's now using CHM there is no need to sync on it


> largemessage have been consumed but not deleted from the disk during backup 
> and live sync
> -----------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2215
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2215
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.3
>            Reporter: yuebao
>            Priority: Major
>
> During the backup and live synchronization, the client consumes the 
> largemessage, then the live crash(the performCachedLargeMessageDeletes method 
> is not executed), after the live startup, the largemessages that have been 
> consumed are not deleted from the disk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to