[
https://issues.apache.org/jira/browse/ARTEMIS-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732955#comment-16732955
]
ASF GitHub Bot commented on ARTEMIS-2215:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244977454
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -727,7 +725,7 @@ private void checkAndCreateDir(final File dir, final
boolean create) {
List<Long> idList = new ArrayList<>();
for (String filename : filenames) {
Long id = getLargeMessageIdFromFilename(filename);
--- End diff --
you can just use a primitive `long` here
> largemessage have been consumed but not deleted from the disk during backup
> and live sync
> -----------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2215
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2215
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: yuebao
> Priority: Major
>
> During the backup and live synchronization, the client consumes the
> largemessage, then the live crash(the performCachedLargeMessageDeletes method
> is not executed), after the live startup, the largemessages that have been
> consumed are not deleted from the disk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
