[
https://issues.apache.org/jira/browse/ARTEMIS-2200?focusedWorklogId=186369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186369
]
ASF GitHub Bot logged work on ARTEMIS-2200:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 15:53
Start Date: 17/Jan/19 15:53
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2459:
ARTEMIS-2200 NPE while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726923
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -1354,13 +1354,15 @@ public void done() {
*/
private void confirmLargeMessageSend(Transaction tx, final Message message)
throws Exception {
LargeServerMessage largeServerMessage = (LargeServerMessage) message;
- if (largeServerMessage.getPendingRecordID() >= 0) {
Review comment:
this shouldn't be necessary. The only caller is synchronizing
largeServerMessage.
I would look for the real cause here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186369)
Time Spent: 50m (was: 40m)
> NPE while dropping/failing large messages on paging
> ---------------------------------------------------
>
> Key: ARTEMIS-2200
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2200
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.7.0, 2.6.3
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Due to a race condition while handling deletion (ie confirmation) of large
> messages dropped/failed due to paging, the Artemis journal try to delete the
> same records twice, throwing NPE while doing it.
> In addition, given that the NPE is unexpected, the broker is not cleaning up
> the pending stores on the OperationContext, leading to some leaking
> OperationContextImpl.TaskHolder instances.
> It is happening with any protocols ie Core, OpenWire, AMQP.
> Are not known yet other bad effects beyond the NPE and the leak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
