[
https://issues.apache.org/jira/browse/ARTEMIS-2200?focusedWorklogId=186405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186405
]
ASF GitHub Bot logged work on ARTEMIS-2200:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/19 16:33
Start Date: 17/Jan/19 16:33
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2459:
ARTEMIS-2200 NPE while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248745062
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/OpenWireLargeMessageTest.java
##########
@@ -103,4 +122,47 @@ public void testSendReceiveLargeMessage() throws
Exception {
assertArrayEquals(body, bytes);
}
}
+
+ @Test
+ public void testFastLargeMessageProducerDropOnPaging() throws Exception {
Review comment:
Can you use this pattern on this test:
```java
AssertionLoggerHandler.startCapture();
try {
...... do your stuff....
Assert.assertFalse(AssertionLoggerHandler.findText("NullPointerException"));
Assert.assertFalse(AssertionLoggerHandler.findText("Cannot find record"));
// or better, use the logger code
} finally {
AssertionLoggerHandler.stopCapture(); // it's important to stopCapture at
the end, there's nothing else cleaning it, that would generate lots of
collected loggers on the AssertionLoggerHandler.
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 186405)
Time Spent: 1h (was: 50m)
> NPE while dropping/failing large messages on paging
> ---------------------------------------------------
>
> Key: ARTEMIS-2200
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2200
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.7.0, 2.6.3
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Due to a race condition while handling deletion (ie confirmation) of large
> messages dropped/failed due to paging, the Artemis journal try to delete the
> same records twice, throwing NPE while doing it.
> In addition, given that the NPE is unexpected, the broker is not cleaning up
> the pending stores on the OperationContext, leading to some leaking
> OperationContextImpl.TaskHolder instances.
> It is happening with any protocols ie Core, OpenWire, AMQP.
> Are not known yet other bad effects beyond the NPE and the leak.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
