[
https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=187993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187993
]
ASF GitHub Bot logged work on ARTEMIS-2170:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/19 06:38
Start Date: 22/Jan/19 06:38
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2427: ARTEMIS-2170
Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456287327
> Just test core message in isolation franz. If an internal header is not
present it will not iterate through
I agree for adhoc unit tests, but common core exchanges include common
headers that are wrongly considered "internal" ie they start with `_AMQ_`,
making `internalProperties = true` and triggering cleaning up that won't clean
anything, given that the real *internal properties* are indeed more specific.
I like your PR (but shocked by GitHUB THB), but I was concerned by the
amount of checks to be performed every time a new property is added and the
real cost to matain that flag consistent: the original version wasn't
considering cases where properties are removed/cleared etc etc: in that case
how much is consistent that flag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 187993)
Time Spent: 4h 40m (was: 4.5h)
> Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-2170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2170
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> CoreMessage::checkProperties perform too many volatile read/write and has a
> too big body just to handle exceptional cases, while
> cleanupInternalProperties is called on the hot path of session send, but is
> performing too many synchronized operations and loopup on TypedProperties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
