[
https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=188003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188003
]
ASF GitHub Bot logged work on ARTEMIS-2170:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/19 07:06
Start Date: 22/Jan/19 07:06
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2427: ARTEMIS-2170
Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456292898
> Re the check its no different than before
The original check was more generic so
that's a great change (in better), because now (your PR) there are no more
false positive :)
That's why I was pushing to test real message exchange: unit tests were not
covering false positive that were happening on real use case.
I like your pr so I'm going to merge it, thanks :)
This pr pr is not just about optimizations but is really ironing from many
pov the original version , especially with concurrent behaviours, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 188003)
Time Spent: 5h 20m (was: 5h 10m)
> Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-2170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2170
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> CoreMessage::checkProperties perform too many volatile read/write and has a
> too big body just to handle exceptional cases, while
> cleanupInternalProperties is called on the hot path of session send, but is
> performing too many synchronized operations and loopup on TypedProperties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
