[ 
https://issues.apache.org/jira/browse/ARTEMIS-2244?focusedWorklogId=192713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192713
 ]

ASF GitHub Bot logged work on ARTEMIS-2244:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Jan/19 09:22
            Start Date: 31/Jan/19 09:22
    Worklog Time Spent: 10m 
      Work Description: CNNJYB commented on pull request #2533: ARTEMIS-2244 
checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer 
timeout
URL: https://github.com/apache/activemq-artemis/pull/2533
 
 
   We found server crash becauseof critical analyzer timeout, thread dump can 
be seen in attachment.    
   Suppose that there is a topic t with two subscriber ta and tb. Some messages 
were routed to subscriber ta, not to tb. When a consumer that subscribe tb is 
created and send ConsumerCredits to server, ServerConsumerImpl will call 
promptDelivery method, then forceDelivery() -> messageQueue.deliverAsync() -> 
deliverRunner will executed in the pageSubscription's executor(step1), then 
checkDepage(step2) -> pageIterator.hasNext(synchronized method) -> next -> 
moveNext, moveNext method will iterate through queue until find a matching 
message. At this time(step1), DeliverRunner call deliver method -> checkDepage 
-> pageIterator.hasNext, this step blocked on CursorIterator which was locked 
by step2, then critical analyzer timeout.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 192713)
            Time Spent: 10m
    Remaining Estimate: 0h

> checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer 
> timeout
> ----------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2244
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2244
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: yuebao
>            Priority: Major
>         Attachments: threaddump.txt
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We found server crash becauseof critical analyzer timeout, thread dump can be 
> seen in attachment.
> Suppose that there is a topic t with two subscriber ta and tb. Some messages 
> were routed to subscriber ta, not to tb. When a consumer that subscribe tb is 
> created and send ConsumerCredits to server, ServerConsumerImpl will call 
> promptDelivery method, then forceDelivery() -> messageQueue.deliverAsync() -> 
> deliverRunner will executed in the pageSubscription's executor(step1), then 
> checkDepage(step2) -> pageIterator.hasNext(synchronized method) -> next -> 
> moveNext, moveNext method will iterate through queue until find a matching 
> message. At this time(step1), DeliverRunner call deliver method -> 
> checkDepage -> pageIterator.hasNext, this step blocked on CursorIterator 
> which was locked by step2, then critical analyzer timeout.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to