[ https://issues.apache.org/jira/browse/ARTEMIS-2244?focusedWorklogId=194776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194776 ]
ASF GitHub Bot logged work on ARTEMIS-2244: ------------------------------------------- Author: ASF GitHub Bot Created on: 05/Feb/19 19:44 Start Date: 05/Feb/19 19:44 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-460776797 Just saw it... it seems that the Critical Analyzer did its job and kicked the server of after a real dead lock? and which you are fixing it here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 194776) Time Spent: 1.5h (was: 1h 20m) > checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer > timeout > ---------------------------------------------------------------------------------- > > Key: ARTEMIS-2244 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2244 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: yuebao > Priority: Major > Attachments: threaddump.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > We found server crash becauseof critical analyzer timeout, thread dump can be > seen in attachment. > Suppose that there is a topic t with two subscriber ta and tb. Some messages > were routed to subscriber ta, not to tb. When a consumer that subscribe tb is > created and send ConsumerCredits to server, ServerConsumerImpl will call > promptDelivery method, then forceDelivery() -> messageQueue.deliverAsync() -> > deliverRunner will executed in the pageSubscription's executor(step1), then > checkDepage(step2) -> pageIterator.hasNext(synchronized method) -> next -> > moveNext, moveNext method will iterate through queue until find a matching > message. At this time(step1), DeliverRunner call deliver method -> > checkDepage -> pageIterator.hasNext, this step blocked on CursorIterator > which was locked by step2, then critical analyzer timeout. -- This message was sent by Atlassian JIRA (v7.6.3#76005)