[
https://issues.apache.org/jira/browse/ARTEMIS-2259?focusedWorklogId=202665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202665
]
ASF GitHub Bot logged work on ARTEMIS-2259:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 14:42
Start Date: 22/Feb/19 14:42
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2561:
ARTEMIS-2259 Client session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368542
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
##########
@@ -1350,10 +1350,12 @@ public void preHandleFailover(RemotingConnection
connection) {
// Needs to be synchronized to prevent issues with occurring concurrently
with close()
@Override
- public void handleFailover(final RemotingConnection backupConnection,
ActiveMQException cause) {
+ public boolean handleFailover(final RemotingConnection backupConnection,
ActiveMQException cause) {
Review comment:
true usually means success. this is a bit confusing. Can you make it
opposite.
meaning handleFailover would return true if succeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202665)
Time Spent: 0.5h (was: 20m)
> Client session not exist if reattach on new connection timeout
> --------------------------------------------------------------
>
> Key: ARTEMIS-2259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2259
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.4
> Reporter: yangwei
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When client session reattach on new connection or session recreation timeout,
> an exception is thrown causing session recreation and consumer recreation
> don't complete. Although client connection failover completes, client session
> actually doesn't work bcs there is no corresponding session channel on server
> side. We close connection if session failover fails to fix the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
