[
https://issues.apache.org/jira/browse/ARTEMIS-2259?focusedWorklogId=203461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203461
]
ASF GitHub Bot logged work on ARTEMIS-2259:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/19 07:28
Start Date: 25/Feb/19 07:28
Worklog Time Spent: 10m
Work Description: wy96f commented on pull request #2561: ARTEMIS-2259
Client session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259701428
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
##########
@@ -771,7 +771,11 @@ private void reconnectSessions(final RemotingConnection
oldConnection,
((CoreRemotingConnection)
connection).syncIDGeneratorSequence(((CoreRemotingConnection)
oldConnection).getIDGeneratorSequence());
for (ClientSessionInternal session : sessionsToFailover) {
- session.handleFailover(connection, cause);
+ if (session.handleFailover(connection, cause)) {
+ connection.destroy();
Review comment:
We'll add test to simulate the scenario where reattach timeout. Just not
sure the proper way to fix the problem:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 203461)
Time Spent: 40m (was: 0.5h)
> Client session not exist if reattach on new connection timeout
> --------------------------------------------------------------
>
> Key: ARTEMIS-2259
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2259
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.4
> Reporter: yangwei
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When client session reattach on new connection or session recreation timeout,
> an exception is thrown causing session recreation and consumer recreation
> don't complete. Although client connection failover completes, client session
> actually doesn't work bcs there is no corresponding session channel on server
> side. We close connection if session failover fails to fix the problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
