[ 
https://issues.apache.org/jira/browse/ARTEMIS-2327?focusedWorklogId=235706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235706
 ]

ASF GitHub Bot logged work on ARTEMIS-2327:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/May/19 06:34
            Start Date: 01/May/19 06:34
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2655: 
ARTEMIS-2327 ExceptionListener invoked when connection level exception
URL: https://github.com/apache/activemq-artemis/pull/2655#discussion_r280012906
 
 

 ##########
 File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
 ##########
 @@ -451,7 +451,9 @@ public Packet sendBlocking(final Packet packet,
             }
 
             if (response == null) {
-               throw 
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
 packet.getType());
+               ActiveMQException e = 
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
 packet.getType());
+               connection.fail(e);
 
 Review comment:
   So i ran a few of them in the normal integration test module (didnt run any 
extra tests tho). Happy for you to run more if you like and merge
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 235706)
    Time Spent: 1h  (was: 50m)

> JMS Connection ExceptionListener not invoked when 
> ActiveMQConnectionTimedOutException occurs on sendPacket
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2327
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2327
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Michael Andre Pearce
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> When a connection level exception occurs it seems in one case, whilst the 
> exception is returned to calling code, exception listeners set at the 
> connection are not being invoked.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to