[
https://issues.apache.org/jira/browse/ARTEMIS-2401?focusedWorklogId=269239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269239
]
ASF GitHub Bot logged work on ARTEMIS-2401:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/19 12:58
Start Date: 28/Jun/19 12:58
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #2731:
[ARTEMIS-2401]: Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r298582545
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##########
@@ -373,6 +372,86 @@ public String sendMessage(final Map<String, String>
headers,
return MBeanInfoHelper.getMBeanAttributesInfo(AddressControl.class);
}
+ @Override
+ public void pause() throws Exception {
+ pause(false);
+ }
+
+ @Override
+ public void pause(boolean persist) throws Exception {
+ if (AuditLogger.isEnabled()) {
+ AuditLogger.pause(addressInfo);
+ }
+ checkStarted();
+
+ clearIO();
+ try {
+ if (!addressInfo.isPaused()) {
+ addressInfo.pause();
+ if (persist) {
+
server.getStorageManager().storeAddressStatus(addressInfo.getId(),
AddressStatus.PAUSED);
+ }
Review comment:
I think this logic should be moved into the `AddressInfo#pause` method so
users of `AddressInfo` get the persistence functionality without having to use
the control object. Also, there needs to be a way to detect multiple
invocations of `pause` so that PAUSED records don't just keep getting added
over and over as that will cause the bindings journal size to increase over
time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 269239)
Time Spent: 4h (was: 3h 50m)
> Implement the Pause method for a Topic
> --------------------------------------
>
> Key: ARTEMIS-2401
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2401
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Enable to pause all the consumers of a topic. New subscriptions being
> registered while the topic is in pause will be paused also.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
