[ 
https://issues.apache.org/jira/browse/ARTEMIS-2401?focusedWorklogId=269270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269270
 ]

ASF GitHub Bot logged work on ARTEMIS-2401:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jun/19 13:21
            Start Date: 28/Jun/19 13:21
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on pull request #2731: 
[ARTEMIS-2401]: Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r298591281
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AddressInfo.java
 ##########
 @@ -136,6 +138,18 @@ public void setBindingRemovedTimestamp(long 
bindingRemovedTimestamp) {
       this.bindingRemovedTimestamp = bindingRemovedTimestamp;
    }
 
+   public void pause() {
 
 Review comment:
   IMO `pause()` and `resume()` should be `synchronized` like they are on 
`QueueImpl`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 269270)
    Time Spent: 5h 10m  (was: 5h)

> Implement the Pause method for a Topic
> --------------------------------------
>
>                 Key: ARTEMIS-2401
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2401
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 2.9.0
>            Reporter: Emmanuel Hugonnet
>            Priority: Major
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Enable to pause all the consumers of a topic. New subscriptions being 
> registered while the topic is in pause will be paused also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to