[
https://issues.apache.org/jira/browse/AMQNET-565?focusedWorklogId=274340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274340
]
ASF GitHub Bot logged work on AMQNET-565:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 20:18
Start Date: 09/Jul/19 20:18
Worklog Time Spent: 10m
Work Description: killnine commented on pull request #9: [AMQNET-565] -
.net standard conversion, project reorganization
URL: https://github.com/apache/activemq-nms-openwire/pull/9
**Background:**
The following PR is related to the two existing JIRA issues
[AMQNET-565](https://issues.apache.org/jira/browse/AMQNET-565) and
[AMQNET-588](https://issues.apache.org/jira/browse/AMQNET-588) to clean up AMQ
NMS and update it to support .net standard 2.0.
**Change Summary:**
- Created new solution file compatible with VS2019
- Created three new, sepearate projects to house the main binaries (.net
standard 2.0), test binaries (.net core 2.2), and documentation (.net standard)
- Replaced Sandcastle documentation with
[DocFx](https://dotnet.github.io/docfx/), as
- Updated build script to follow [AMQ NMS
API](https://github.com/apache/activemq-nms-api/blob/master/package.ps1)'s
example
- Updated to NUnit3 and made minor unit test changes to replace deprecated
functionality
- Removed incompatible reference, Ionic.ZLib, and replaced with first-party
compression solution
- Updated README and added RELEASE documents according to AMQ NMS API's
example
**Areas to Focus:**
- I'm struggling to get unit testing running against a local test broker. So
if someone can test that out as well, I'd appreciate it greatly.
- The package.ps1 script doesn't seem to be working but I'm not familiar
enough with what it should be doing to debug that much
- RELEASE.md probably needs some clarification. This must be for how the
package is released to Apache but I just don't understand it.
- I will try and call out any code change areas below so it's clear when I
do more than just 'convert'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274340)
Time Spent: 2h 40m (was: 2.5h)
> Dotnet core port
> -----------------
>
> Key: AMQNET-565
> URL: https://issues.apache.org/jira/browse/AMQNET-565
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ
> Reporter: Wojtek Kulma
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Apache.NMS.ActiveMQ should be ported for dotnet core.
> For now the following error is rises:
> D:\RiderProjects\syncro [master ≡ +1 ~1 -1 !]> dotnet add package
> Apache.NMS.ActiveMQ
> Microsoft (R) Build Engine version 15.1.1012.6693
> Copyright (C) Microsoft Corporation. All rights reserved.
> Writing C:\Users\wkulma\AppData\Local\Temp\tmp9A2E.tmp
> info : Adding PackageReference for package 'Apache.NMS.ActiveMQ' into project
> 'D:\RiderProjects\syncro\syncro.fsproj'.
> log : Restoring packages for D:\RiderProjects\syncro\syncro.fsproj...
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json
> info : CACHE https://api.nuget.org/v3-flatcontainer/fsharp.core/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.core/4.1.17/fsharp.core.4.1.17.nupkg
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/1.0.5/fsharp.net.sdk.1.0.5.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json 611ms
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> 481ms
> error: Package Apache.NMS.ActiveMQ 1.7.2 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS.ActiveMQ 1.7.2 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: Package Apache.NMS 1.7.1 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS 1.7.1 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net20-cf (.NETFramework,Version=v2.0,Profile=CompactFramework)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: One or more packages are incompatible with .NETCoreApp,Version=v1.1.
> error: Package 'Apache.NMS.ActiveMQ' is incompatible with 'all' frameworks in
> project 'D:\RiderProjects\syncro\syncro.fsproj'.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
