[
https://issues.apache.org/jira/browse/AMQNET-565?focusedWorklogId=274346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274346
]
ASF GitHub Bot logged work on AMQNET-565:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 20:22
Start Date: 09/Jul/19 20:22
Worklog Time Spent: 10m
Work Description: killnine commented on pull request #9: [AMQNET-565] -
.net standard conversion, project reorganization
URL:
https://github.com/apache/activemq-nms-openwire/pull/9#discussion_r301776709
##########
File path: src/CompressionPolicy.cs
##########
@@ -16,24 +16,20 @@
*/
using System.IO;
+using System.IO.Compression;
namespace Apache.NMS.ActiveMQ
{
- /// <summary>
- /// Default Compression policy for NMS.ActiveMQ uses the built in
GZipStream
- /// to compress and decompress the message body. This is not compatible
with
- /// compression used by ActiveMQ so users should use this with caution.
- /// </summary>
public class CompressionPolicy : ICompressionPolicy
{
public Stream CreateCompressionStream(Stream data)
{
- return new Ionic.Zlib.ZlibStream(data,
Ionic.Zlib.CompressionMode.Compress);
+ return new GZipStream(data, CompressionMode.Compress);
Review comment:
Based on documentation from microsoft and some information on SO, this
should be sufficient. The comment above has me concerned. Why not just use
GZipStream from the start? Was this some special functionality added for a
different compression mode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274346)
Time Spent: 3h 10m (was: 3h)
> Dotnet core port
> -----------------
>
> Key: AMQNET-565
> URL: https://issues.apache.org/jira/browse/AMQNET-565
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ
> Reporter: Wojtek Kulma
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Apache.NMS.ActiveMQ should be ported for dotnet core.
> For now the following error is rises:
> D:\RiderProjects\syncro [master ≡ +1 ~1 -1 !]> dotnet add package
> Apache.NMS.ActiveMQ
> Microsoft (R) Build Engine version 15.1.1012.6693
> Copyright (C) Microsoft Corporation. All rights reserved.
> Writing C:\Users\wkulma\AppData\Local\Temp\tmp9A2E.tmp
> info : Adding PackageReference for package 'Apache.NMS.ActiveMQ' into project
> 'D:\RiderProjects\syncro\syncro.fsproj'.
> log : Restoring packages for D:\RiderProjects\syncro\syncro.fsproj...
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json
> info : CACHE https://api.nuget.org/v3-flatcontainer/fsharp.core/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.core/4.1.17/fsharp.core.4.1.17.nupkg
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/1.0.5/fsharp.net.sdk.1.0.5.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json 611ms
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> 481ms
> error: Package Apache.NMS.ActiveMQ 1.7.2 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS.ActiveMQ 1.7.2 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: Package Apache.NMS 1.7.1 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS 1.7.1 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net20-cf (.NETFramework,Version=v2.0,Profile=CompactFramework)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: One or more packages are incompatible with .NETCoreApp,Version=v1.1.
> error: Package 'Apache.NMS.ActiveMQ' is incompatible with 'all' frameworks in
> project 'D:\RiderProjects\syncro\syncro.fsproj'.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
