[
https://issues.apache.org/jira/browse/ARTEMIS-2449?focusedWorklogId=291384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291384
]
ASF GitHub Bot logged work on ARTEMIS-2449:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/19 16:31
Start Date: 08/Aug/19 16:31
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2790:
ARTEMIS-2449 limit size of producer details
URL: https://github.com/apache/activemq-artemis/pull/2790#discussion_r312129457
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
##########
@@ -175,7 +176,7 @@
private final OperationContext context;
// Session's usage should be by definition single threaded, hence it's not
needed to use a concurrentHashMap here
- protected final Map<SimpleString, Pair<Object, AtomicLong>>
targetAddressInfos = new HashMap<>();
+ protected final Map<SimpleString, Pair<Object, AtomicLong>>
targetAddressInfos = new MaxSizeMap<>(100);
Review comment:
Can this be configurable, 100 is a bit arbitrary especially as prev was
unlimited
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 291384)
Time Spent: 0.5h (was: 20m)
> Limit size of producer details
> ------------------------------
>
> Key: ARTEMIS-2449
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2449
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The core server session tracks details about producers like what addresses
> have had messages sent to them, the most recent message ID sent to each
> address, and the number of messages sent to each address. This information is
> made available to users via the {{listProducersInfoAsJSON}} method on the
> various management interfaces (JMX, web console, etc.). However, in
> situations where a server session is long lived (e.g. in a pool) and is used
> to send to many different addresses (e.g. randomly named temporary JMS
> queues) this info can accumulate to a problematic degree. Therefore, we
> should limit the amount of producer details saved by the session.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
