[
https://issues.apache.org/jira/browse/ARTEMIS-2449?focusedWorklogId=291449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291449
]
ASF GitHub Bot logged work on ARTEMIS-2449:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/19 17:36
Start Date: 08/Aug/19 17:36
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #2790: ARTEMIS-2449
limit size of producer details
URL: https://github.com/apache/activemq-artemis/pull/2790#discussion_r312158464
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
##########
@@ -175,7 +176,7 @@
private final OperationContext context;
// Session's usage should be by definition single threaded, hence it's not
needed to use a concurrentHashMap here
- protected final Map<SimpleString, Pair<Object, AtomicLong>>
targetAddressInfos = new HashMap<>();
+ protected final Map<SimpleString, Pair<Object, AtomicLong>>
targetAddressInfos = new MaxSizeMap<>(100);
Review comment:
There won't be any error. The map will just silently drop the oldest entry
when the maxSize is hit. You'll be able to send to any destination again that
was dropped previously due to maxSize. This information is only for
administrative use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 291449)
Time Spent: 1h (was: 50m)
> Limit size of producer details
> ------------------------------
>
> Key: ARTEMIS-2449
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2449
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The core server session tracks details about producers like what addresses
> have had messages sent to them, the most recent message ID sent to each
> address, and the number of messages sent to each address. This information is
> made available to users via the {{listProducersInfoAsJSON}} method on the
> various management interfaces (JMX, web console, etc.). However, in
> situations where a server session is long lived (e.g. in a pool) and is used
> to send to many different addresses (e.g. randomly named temporary JMS
> queues) this info can accumulate to a problematic degree. Therefore, we
> should limit the amount of producer details saved by the session.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
