ASF GitHub Bot logged work on ARTEMIS-2451:

                Author: ASF GitHub Bot
            Created on: 14/Aug/19 07:06
            Start Date: 14/Aug/19 07:06
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2794: 
ARTEMIS-2451 limit size of destination cache
URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313730591

 File path: 
 @@ -97,7 +98,7 @@
    private final Set<SimpleString> tempQueues = new ConcurrentHashSet<>();
-   private final Set<SimpleString> knownDestinations = new 
+   private final ConcurrentMaxSizeCache<SimpleString> knownDestinations = new 
 Review comment:
   this will actually cause issues if someone is using temp destinations, and 
has say more than 100 legitimately. and creates the consumers later, as the 
consumer will check it its known, which now it wont and will throw an error. 
   This will at least mean people can increase that setting if they need. 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 294530)
    Time Spent: 0.5h  (was: 20m)

> Limit size of destination cache
> -------------------------------
>                 Key: ARTEMIS-2451
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2451
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> This is the client-side version of ARTEMIS-2449. Simply put, there is no 
> limit on the destination cache for a core JMS client. For a long-lived 
> connection sending to lots of different destinations (e.g. in a request-reply 
> use-case involving temporary queues) this can present a significant problem.

This message was sent by Atlassian JIRA

Reply via email to