ASF GitHub Bot logged work on ARTEMIS-2451:

                Author: ASF GitHub Bot
            Created on: 14/Aug/19 07:19
            Start Date: 14/Aug/19 07:19
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2794: 
ARTEMIS-2451 limit size of destination cache
URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313734672

 File path: 
 @@ -266,6 +266,24 @@ public void testForTempQueueTargetInfosSizeLimit() throws 
Exception {
+   @Test
+   public void testForKnownAddressSizeLimit() throws Exception {
+      try {
+         conn = createConnection();
+         Session s = conn.createSession(false, Session.AUTO_ACKNOWLEDGE);
+         for (int i = 0; i < 200; i++) {
+            TemporaryQueue temporaryQueue = s.createTemporaryQueue();
+            MessageProducer producer = s.createProducer(temporaryQueue);
+            producer.send(s.createMessage());
+         }
+         assertTrue(((ActiveMQConnection)conn).getKnownDestinations().size() 
<= 100);
 Review comment:
   An alternative solution to this problem is remove knownDestination entirely, 
and have a reference to the session & connection in the Destination itself, and 
then it will no longer be needed, as we can do the check directly on the 
destination, e.g. something like
      ` jbdest.getConnection == connection`
   Removing the need for the set
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 294543)
    Time Spent: 1h 20m  (was: 1h 10m)

> Limit size of destination cache
> -------------------------------
>                 Key: ARTEMIS-2451
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2451
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
> This is the client-side version of ARTEMIS-2449. Simply put, there is no 
> limit on the destination cache for a core JMS client. For a long-lived 
> connection sending to lots of different destinations (e.g. in a request-reply 
> use-case involving temporary queues) this can present a significant problem.

This message was sent by Atlassian JIRA

Reply via email to