[ 
https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295284
 ]

ASF GitHub Bot logged work on ARTEMIS-2452:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Aug/19 08:10
            Start Date: 15/Aug/19 08:10
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2793: 
ARTEMIS-2452 group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupRequestMessage.java
 ##########
 @@ -34,12 +34,14 @@ public BackupRequestMessage() {
    }
 
    public BackupRequestMessage(int backupSize,
+                               SimpleString nodeID,
                                String journalDirectory,
                                String bindingsDirectory,
                                String largeMessagesDirectory,
                                String pagingDirectory) {
       super(BACKUP_REQUEST);
       this.backupSize = backupSize;
+      this.nodeID = nodeID;
 
 Review comment:
   Please make a v2 version, this would be a breaking change, for anyone with 
existing clusters
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 295284)
    Time Spent: 1h 50m  (was: 1h 40m)

> group-name ignored in shared store colocated setup
> --------------------------------------------------
>
>                 Key: ARTEMIS-2452
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2452
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.9.0
>            Reporter: Francesco Nigro
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to