[
https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295291
]
ASF GitHub Bot logged work on ARTEMIS-2452:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:17
Start Date: 15/Aug/19 08:17
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2793: ARTEMIS-2452
group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314213953
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ColocatedHAManager.java
##########
@@ -163,6 +174,23 @@ private synchronized boolean
activateSharedStoreBackup(String journalDirectory,
return true;
}
+ private TopologyMember validateBackupGroupName(SimpleString nodeID) {
+ // Older versions of artemis don't send the nodeID in
BackupRequestMessage:
+ // in this case we cannot trust the request, making the requesting server
Review comment:
It was working fine because you haven't had any other member of topology
with a group name and been lucky, I believe :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 295291)
Time Spent: 2h 50m (was: 2h 40m)
> group-name ignored in shared store colocated setup
> --------------------------------------------------
>
> Key: ARTEMIS-2452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2452
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
