[
https://issues.apache.org/jira/browse/ARTEMIS-2617?focusedWorklogId=384128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384128
]
ASF GitHub Bot logged work on ARTEMIS-2617:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/20 18:16
Start Date: 09/Feb/20 18:16
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2975: ARTEMIS-2617
Improve AMQP Journal loading
URL: https://github.com/apache/activemq-artemis/pull/2975#issuecomment-583875806
@michaelandrepearce I suppose you are interested in numbers: in my syntethic
tests a 2 GB journal with very small messages (to create tons of garbage due to
the infrastructure of messages) wasn't able to be loaded by a broker with `4GB`
heap size, always leading to a OOM: now it can be loaded without relevant GC
pauses eg
We're not quite yet at the same level of Core messages, but very near: I
think that the duplicate `address` is responsible of the difference here.
The commit that allows to half-brute force search `x-opt-delivery-time` is
what I'm not sure about:
- that method should be optimized and performed optimally by proton itself
IMO (nudge nudge @tabish121 @gemmellr), but I would be super happy to provide a
PR for it
- currently it can give rare false positive (causing message scanning when
not necessary)
- I've yet to verify how it behave with many message annotations and longer
messages
If @michaelandrepearce has some real journal to test with and compare with
`master` it would be great, given that this change can affect positively your
usage of the broker ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384128)
Time Spent: 50m (was: 40m)
> Improve AMQP Journal loading
> ----------------------------
>
> Key: ARTEMIS-2617
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2617
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Journal loading AMQP messages always force decoding message data thus
> creating garbage
> on broker startup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
