[
https://issues.apache.org/jira/browse/ARTEMIS-2617?focusedWorklogId=384664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384664
]
ASF GitHub Bot logged work on ARTEMIS-2617:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/20 19:21
Start Date: 10/Feb/20 19:21
Worklog Time Spent: 10m
Work Description: tabish121 commented on pull request #2975: ARTEMIS-2617
Improve AMQP Journal loading
URL: https://github.com/apache/activemq-artemis/pull/2975#discussion_r377264879
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java
##########
@@ -156,6 +157,72 @@ public void testCreateMessageForPersistenceDataReload()
throws ActiveMQException
assertEquals(TEST_TO_ADDRESS, message.getAddress());
}
+ @Test
Review comment:
The tests seem a bit simplistic for such a change, what about annotations
sections with many different annotations or annotations that don't match what
you are looking for or are very very close but not quite what you are looking
for etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384664)
Time Spent: 2h (was: 1h 50m)
> Improve AMQP Journal loading
> ----------------------------
>
> Key: ARTEMIS-2617
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2617
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Journal loading AMQP messages always force decoding message data thus
> creating garbage
> on broker startup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
