[
https://issues.apache.org/jira/browse/ARTEMIS-2176?focusedWorklogId=388922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388922
]
ASF GitHub Bot logged work on ARTEMIS-2176:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/20 17:14
Start Date: 18/Feb/20 17:14
Worklog Time Spent: 10m
Work Description: gaohoward commented on issue #2432: [ARTEMIS-2176] RA
connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#issuecomment-587572338
> There is outstanding comments on this, are these being addressed?
Hi Guys,
I've tried some refactoring based on @spyrkob's work. Basically I extracted
the relevant properties from ServicerLocator into a ServerLocatorConfig class
so that it can be reused for creating new locators in XARecoveryConfig. Please
take a look at my branch and tell me what you think:
https://github.com/gaohoward/activemq-artemis/blob/spyrkob-ARTEMIS-2176/artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java#L48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 388922)
Time Spent: 40m (was: 0.5h)
> RA connection properties are not propagated to XARecoveryConfig
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2176
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: Bartosz Spyrko-Smietanko
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> XARecoveryConfig#createServerLocator uses only
> TransportConfiguration/DiscoveryGroupConfiguration to create a new instance
> of ServerLocator. That means that connection properties like connectionTTL or
> callFailoverTime are ignored. This can lead to network issues - eg.
> [https://issues.jboss.org/browse/WFLY-10725]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
