[
https://issues.apache.org/jira/browse/ARTEMIS-2176?focusedWorklogId=389882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389882
]
ASF GitHub Bot logged work on ARTEMIS-2176:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 10:43
Start Date: 20/Feb/20 10:43
Worklog Time Spent: 10m
Work Description: spyrkob commented on issue #2432: [ARTEMIS-2176] RA
connection properties are not propagated to XARecov…
URL: https://github.com/apache/activemq-artemis/pull/2432#issuecomment-588939265
@gaohoward I think it looks good, but I'm not that familiar with Artemis :)
My only comment would be whether the ServerLocatorConfig#copyFrom could be a
constructor instead of copy method - I think it would be more readable.
Should I merge your commit in and update this PR or is it easier if you open
a new PR to replace this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389882)
Time Spent: 1h (was: 50m)
> RA connection properties are not propagated to XARecoveryConfig
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2176
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: Bartosz Spyrko-Smietanko
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> XARecoveryConfig#createServerLocator uses only
> TransportConfiguration/DiscoveryGroupConfiguration to create a new instance
> of ServerLocator. That means that connection properties like connectionTTL or
> callFailoverTime are ignored. This can lead to network issues - eg.
> [https://issues.jboss.org/browse/WFLY-10725]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
