[
https://issues.apache.org/jira/browse/ARTEMIS-2654?focusedWorklogId=402146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402146
]
ASF GitHub Bot logged work on ARTEMIS-2654:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/20 13:22
Start Date: 12/Mar/20 13:22
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #3015:
ARTEMIS-2654 Improving Page cleanup and Operation Context
URL: https://github.com/apache/activemq-artemis/pull/3015#discussion_r391616057
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
##########
@@ -612,26 +640,15 @@ protected void onDeletePage(Page deletedPage) throws
Exception {
}
/**
+ * This method will store the last known position for paging right before
we stopped paging.
* @param cursorList
* @param currentPage
* @throws Exception
*/
protected void storeBookmark(ArrayList<PageSubscription> cursorList, Page
currentPage) throws Exception {
- try {
- // First step: Move every cursor to the next bookmarked page (that
was just created)
- for (PageSubscription cursor : cursorList) {
- cursor.confirmPosition(new
PagePositionImpl(currentPage.getPageId(), -1));
- }
-
- // we just need to make sure the storage is done..
- // if the thread pool is full, we will just log it once instead of
looping
- if (!storageManager.waitOnOperations(5000)) {
-
ActiveMQServerLogger.LOGGER.problemCompletingOperations(storageManager.getContext());
- }
- } finally {
- for (PageSubscription cursor : cursorList) {
- cursor.enableAutoCleanup();
- }
+ // Move every cursor to the next bookmarked page
Review comment:
how now are we making sure storage is done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 402146)
Time Spent: 40m (was: 0.5h)
> Improve Paging.Stop cleanup
> ---------------------------
>
> Key: ARTEMIS-2654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2654
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.11.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There's a Blocking operation on Page.stopPaging and cleanup should use its
> own OperationContext.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
