[
https://issues.apache.org/jira/browse/ARTEMIS-2654?focusedWorklogId=402145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-402145
]
ASF GitHub Bot logged work on ARTEMIS-2654:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/20 13:22
Start Date: 12/Mar/20 13:22
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #3015:
ARTEMIS-2654 Improving Page cleanup and Operation Context
URL: https://github.com/apache/activemq-artemis/pull/3015#discussion_r391615802
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
##########
@@ -517,6 +528,23 @@ protected void
cleanupComplete(ArrayList<PageSubscription> cursorList) throws Ex
storeBookmark(cursorList, currentPage);
+ // notice this will be using the OperationContext started by cleanup
+ storageManager.afterCompleteOperations(new IOCallback() {
+ @Override
+ public void done() {
+
+ for (PageSubscription cursor : cursorList) {
+ cursor.enableAutoCleanup();
+ }
+ }
+
+ @Override
+ public void onError(int errorCode, String errorMessage) {
Review comment:
what about error handling?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 402145)
Time Spent: 0.5h (was: 20m)
> Improve Paging.Stop cleanup
> ---------------------------
>
> Key: ARTEMIS-2654
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2654
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.11.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There's a Blocking operation on Page.stopPaging and cleanup should use its
> own OperationContext.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
