[ 
https://issues.apache.org/jira/browse/ARTEMIS-1975?focusedWorklogId=409720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409720
 ]

ASF GitHub Bot logged work on ARTEMIS-1975:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Mar/20 18:48
            Start Date: 25/Mar/20 18:48
    Worklog Time Spent: 10m 
      Work Description: franz1981 commented on pull request #3048: ARTEMIS-1975 
Fixing LargeMessage encoding for replication
URL: https://github.com/apache/activemq-artemis/pull/3048#discussion_r398090739
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessagePersister.java
 ##########
 @@ -96,10 +91,11 @@ public void encode(ActiveMQBuffer buffer, Message record) {
          properties.encode(buffer.byteBuf());
       }
 
-      ByteBuf savedEncodeBuffer = getSavedEncodeBuffer(record);
+      ByteBuf savedEncodeBuffer = msgEncode.getSavedEncodeBuffer();
       buffer.writeBytes(savedEncodeBuffer, 0, savedEncodeBuffer.writerIndex());
-      savedEncodeBuffer.release();
-      msgEncode.temporaryBuffer = null;
+      msgEncode.releaseEncodedBuffer();
+      msgEncode.releaseEncodedBuffer(); // We need two releases here, one for 
the retain when the savedEncodeBuffer was called
 
 Review comment:
   I'm still fighting to find some water :( 
   I would like you to be happy about the naming anyway, impl-wire you can use 
https://netty.io/4.1/api/io/netty/util/ReferenceCounted.html#release-int- that 
would release the buffer the number of times you need (and can return a boolean 
if you need to do something right after too)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 409720)
    Time Spent: 5h 50m  (was: 5h 40m)

> Real LargeMessage support for AMQP
> ----------------------------------
>
>                 Key: ARTEMIS-1975
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1975
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.6.2, 2.11.0
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.12.0
>
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> This task in between a bug and an improvement.
>  
> Currently LargeMessages in AMQP are converted to Core.
> We should at least not require a conversion.. keep large messages in AMQP 
> without conversions.
>  
> Optionally it would be nice to stream in AMQP as well. but if we can at least 
> prevent conversions it's already a big win!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to