[
https://issues.apache.org/jira/browse/ARTEMIS-1975?focusedWorklogId=414158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414158
]
ASF GitHub Bot logged work on ARTEMIS-1975:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 16:53
Start Date: 01/Apr/20 16:53
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3055: ARTEMIS-1975 Fix
AMQP paged large message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055#issuecomment-607367530
I've noticed a thing while working on this PR on `PagedMessageImpl::decode`:
```java
if (isLargeMessage) {
int largeMessageHeaderSize = buffer.readInt();
if (storageManager == null) {
largeMessageLazyData = new byte[largeMessageHeaderSize];
buffer.readBytes(largeMessageLazyData);
} else {
```
the case where `storageManager == null` and is a core message; why `usageUp`
isn't called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 414158)
Time Spent: 6h 40m (was: 6.5h)
> Real LargeMessage support for AMQP
> ----------------------------------
>
> Key: ARTEMIS-1975
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1975
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.6.2, 2.11.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> This task in between a bug and an improvement.
>
> Currently LargeMessages in AMQP are converted to Core.
> We should at least not require a conversion.. keep large messages in AMQP
> without conversions.
>
> Optionally it would be nice to stream in AMQP as well. but if we can at least
> prevent conversions it's already a big win!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
