[
https://issues.apache.org/jira/browse/ARTEMIS-2682?focusedWorklogId=421665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-421665
]
ASF GitHub Bot logged work on ARTEMIS-2682:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/20 21:45
Start Date: 13/Apr/20 21:45
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #3043:
ARTEMIS-2682: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-613113293
So i managed to get this to compile finally.
I have to say the tests are a nice addition.
That said having a single class (as was) for the conversion to and from core
or two seperate is really negligible in difference and is more personal coding
preference/ style of a coder.. it makes no difference in ability to maintain.
Im personally much more in favour of a single class containing the
conversion logic as it keeps it clearly contained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 421665)
Time Spent: 2h 50m (was: 2h 40m)
> OpenWireMessageConverter refactoring
> ------------------------------------
>
> Key: ARTEMIS-2682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2682
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: OpenWire
> Affects Versions: 2.12.0
> Reporter: Federico Valeri
> Priority: Minor
> Labels: openwire, refactoring
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> I'm proposing the {{OpenWireMessageConverter}} refactoring to have a similar
> layout as the {{AMQPConverter}}. The latter has two dedicated classes for
> inbound and outbound messages with a singleton entry point for the converter.
> This change is basically doing the same without semantics change and also
> adding a unit test for the converter. I'm also eliminating some duplicated
> code, but the bulk of the code remains untouched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
