[
https://issues.apache.org/jira/browse/ARTEMIS-2682?focusedWorklogId=418016&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418016
]
ASF GitHub Bot logged work on ARTEMIS-2682:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/20 22:07
Start Date: 07/Apr/20 22:07
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #3043:
ARTEMIS-2682: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-610644528
@clebertsuconic i keep getting a compile error with this pr due to a
classname not matching its file.
I will try full rebase tomorrow if given time. That said i havent even
started to review this as need to have it compile first.
Also with all the basic compile issues, and the amount of change which makes
it hard to work out what actually had changed, this is a high risk pr that
clearly can introduce an accidental issue (as example it hasnt been compiling)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418016)
Time Spent: 1h 50m (was: 1h 40m)
> OpenWireMessageConverter refactoring
> ------------------------------------
>
> Key: ARTEMIS-2682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2682
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: OpenWire
> Affects Versions: 2.12.0
> Reporter: Federico Valeri
> Priority: Minor
> Labels: openwire, refactoring
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I'm proposing the {{OpenWireMessageConverter}} refactoring to have a similar
> layout as the {{AMQPConverter}}. The latter has two dedicated classes for
> inbound and outbound messages with a singleton entry point for the converter.
> This change is basically doing the same without semantics change and also
> adding a unit test for the converter. I'm also eliminating some duplicated
> code, but the bulk of the code remains untouched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
