[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=444118&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444118
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/20 05:02
Start Date: 11/Jun/20 05:02
Worklog Time Spent: 10m
Work Description: jsmucr commented on a change in pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r438543888
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
Clearing the value using `""` does not work, at least not for a filter.
```
//...
public static Filter createFilter(final SimpleString filterStr) throws
ActiveMQException {
if (filterStr == null || filterStr.length() == 0) {
return null;
}
// ...
```
So there would have to be a breaking change anyway, just to achieve this.
I understand the issue with resetting the whole configuration. Maybe there
could be a toggle to enable this.
I'm working for a cloud-based EDI provider and our ultimate goal is to have
all of our infrastructure configurable via Ansible (or similar tools) so that
in case of a major failure there'd be no need to perform too many manual steps
in order to rebuild the service from scratch. That makes the Ansible repository
the only place to store our configuration, and therefore it would be highly
beneficial if I could redeploy the Artemis configuration from there. :-) It
would also open the way to create a bit more user friendly tool to design the
MQ related infrastructure.
I'd be happy to hear about the way you do it in your company. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 444118)
Time Spent: 3h 10m (was: 3h)
> Allow for removing current queue filter
> ---------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Currently the queue filter cannot be removed because of a filter ~ null check
> leading to quitting the PostOfficeImpl#updateQueue() instead of setting the
> queue filter to empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
