[
https://issues.apache.org/jira/browse/ARTEMIS-2797?focusedWorklogId=443733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443733
]
ASF GitHub Bot logged work on ARTEMIS-2797:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/20 13:39
Start Date: 10/Jun/20 13:39
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r438123727
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration
queueConfiguration) throws Ex
queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
}
Filter filter =
FilterImpl.createFilter(queueConfiguration.getFilterString());
- if (filter != null && !filter.equals(queue.getFilter())) {
+ if ((filter == null) && (queue.getFilter() != null)) {
Review comment:
The idea of the null checks, is so that you update just a partial part,
e,g, if i only wanted to update say exclusive consumer, i wouldnt have to know
all the rest of the config. And there for the update had to be a positive (e.g.
it was set) change, to avoid an accident. Maybe could be that the approach here
is to use "" empty string as a single its a positive change, e.g. theres a
difference semantically in that its been set to "" its not null, and there for
then could use that to clear it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 443733)
Time Spent: 2h 40m (was: 2.5h)
> Allow for removing current queue filter
> ---------------------------------------
>
> Key: ARTEMIS-2797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2797
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Jan Šmucr
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.14.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently the queue filter cannot be removed because of a filter ~ null check
> leading to quitting the PostOfficeImpl#updateQueue() instead of setting the
> queue filter to empty.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
