[ 
https://issues.apache.org/jira/browse/ARTEMIS-2920?focusedWorklogId=491954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491954
 ]

ASF GitHub Bot logged work on ARTEMIS-2920:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/20 12:37
            Start Date: 28/Sep/20 12:37
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on a change in pull request #3280:
URL: https://github.com/apache/activemq-artemis/pull/3280#discussion_r495905050



##########
File path: artemis-features/pom.xml
##########
@@ -30,6 +30,20 @@
     </properties>
 
     <dependencies>
+        <dependency>
+            <groupId>org.apache.karaf.features</groupId>
+            <artifactId>framework</artifactId>
+            <version>${karaf.version}</version>
+            <type>xml</type>
+            <classifier>features</classifier>

Review comment:
       Should these new deps be 'provided' scope like the other existing dep 
was?
   
   Also, since the JIRA says the build is failing while downloading these deps, 
that suggests it already knows about the deps being required, and the build 
passing on other JDKs suggests that process succeeds there. That makes me 
wonder if perhaps the fix needed actually isnt that they need added as deps? 
From the description it sounds like maybe Karaf failed to download them, so I 
guess this will just make Maven download them initially instead so Karaf then 
doesnt have to?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 491954)
    Time Spent: 20m  (was: 10m)

> ActiveMQ Artemis Features build fails using IBM JDK 1.8
> -------------------------------------------------------
>
>                 Key: ARTEMIS-2920
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2920
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Domenico Francesco Bruscino
>            Assignee: Domenico Francesco Bruscino
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> ActiveMQ Artemis Features build fails with the following error using IBM JDK 
> 1.8:
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.karaf.tooling:karaf-maven-plugin:4.2.8:verify (verify) on project 
> artemis-features: Unable to load features descriptors: Error:
> [ERROR]       Error downloading 
> mvn:org.apache.karaf.features/enterprise/4.2.8/xml/features
> [ERROR]       Error downloading 
> mvn:org.apache.karaf.features/framework/4.2.8/xml/features
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to