[
https://issues.apache.org/jira/browse/ARTEMIS-2920?focusedWorklogId=491980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491980
]
ASF GitHub Bot logged work on ARTEMIS-2920:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/20 13:41
Start Date: 28/Sep/20 13:41
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3280:
URL: https://github.com/apache/activemq-artemis/pull/3280#discussion_r495947633
##########
File path: artemis-features/pom.xml
##########
@@ -30,6 +30,20 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.karaf.features</groupId>
+ <artifactId>framework</artifactId>
+ <version>${karaf.version}</version>
+ <type>xml</type>
+ <classifier>features</classifier>
Review comment:
So what I am saying is that since this works on other JDKs already, and
even on the IBM JDK it clearly knows about the items for it to get as far as
trying and failing to download them, that would suggest to me that it isnt a
pom dependency issue at the core of the problem. I wouldnt expect that to
really shouldnt change between e.g different JDK8 instances. Other stuff like
TLS handling etc is known to vary though, and might be more likely to cause
issues; is there more detail around the download failure errors?
It just seems like by doing this you would perhaps (I'm no karaf expert
either) instead be avoiding the actual issue by adding the bits as dependencies
of the pom and having Maven download them into the local repo in advance during
the build so Karaf doesnt need to, rather than fixing whatever is preventing
Karaf from downloading them when it needs them (which I am presuming is how it
is succeeding in doing the build on other JDKs for this to work there
currently?).
If it is done it seems odd to have one dep at provided scope and the others
at compile. That would mean there was a fixed-version dep on particular karaf
bits in the pom, which may not be the karaf verison something using this uses,
which using provided scope would presumably avoid (I'd guess thats why the
existing dep uses provided).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 491980)
Time Spent: 40m (was: 0.5h)
> ActiveMQ Artemis Features build fails using IBM JDK 1.8
> -------------------------------------------------------
>
> Key: ARTEMIS-2920
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2920
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> ActiveMQ Artemis Features build fails with the following error using IBM JDK
> 1.8:
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.karaf.tooling:karaf-maven-plugin:4.2.8:verify (verify) on project
> artemis-features: Unable to load features descriptors: Error:
> [ERROR] Error downloading
> mvn:org.apache.karaf.features/enterprise/4.2.8/xml/features
> [ERROR] Error downloading
> mvn:org.apache.karaf.features/framework/4.2.8/xml/features
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
