[
https://issues.apache.org/jira/browse/ARTEMIS-2919?focusedWorklogId=492421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-492421
]
ASF GitHub Bot logged work on ARTEMIS-2919:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/20 12:36
Start Date: 29/Sep/20 12:36
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3279:
URL: https://github.com/apache/activemq-artemis/pull/3279#discussion_r496680134
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -1317,6 +1317,21 @@ public Object getBrokerProperty(SimpleString key) {
return extra.getProperty(key);
}
+ @Override
+ public final org.apache.activemq.artemis.api.core.Message
setIngressTimestamp() {
+ setMessageAnnotation(AMQPMessageSupport.INGRESS_TIMESTAMP,
System.currentTimeMillis());
Review comment:
I see the impl changed to supplying epoch based millisecond value.
If this is going to be the case then I'd say it shouldnt use the same
x-opt-ingress-timestamp annotation key as the qpidd broker the feature
inspiration came from, since the two would then be using the same key for two
differnet styles of value. That would rather break interop between applications
and/or the two brokers (at least without significant hoop jumping), rather
defeating the point of using the same protocol and annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 492421)
Time Spent: 1h 50m (was: 1h 40m)
> Support timestamping incoming messages
> --------------------------------------
>
> Key: ARTEMIS-2919
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2919
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
