[
https://issues.apache.org/jira/browse/ARTEMIS-2919?focusedWorklogId=518378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518378
]
ASF GitHub Bot logged work on ARTEMIS-2919:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/20 10:48
Start Date: 01/Dec/20 10:48
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3279:
URL: https://github.com/apache/activemq-artemis/pull/3279#discussion_r533239509
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AMQPMessageSupport.java
##########
@@ -99,6 +99,11 @@
*/
public static final Symbol ROUTING_TYPE =
Symbol.getSymbol("x-opt-routing-type");
+ /**
+ * Attribute used to mark the Broker-defined ingress time assigned to the
message
+ */
+ public static final Symbol INGRESS_TIMESTAMP =
Symbol.getSymbol("x-opt-ingress-timestamp-millis");
Review comment:
The units in the name seem unnecessary, even a bit ugly, given most
(all?) related values are in millis. I know you are adding that to avoid a
collision with behaviour elsewhere though, but I'd go another way personally to
achieve that.
In thinking on it, I'd suggest just "x-opt-ingress-time" instead.
(The spec-defined time related fields are named \<foo\>-time, albeit the
field name doesn't go on the wire at all for those)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 518378)
Time Spent: 2h 40m (was: 2.5h)
> Support timestamping incoming messages
> --------------------------------------
>
> Key: ARTEMIS-2919
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2919
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
