[ 
https://issues.apache.org/jira/browse/ARTEMIS-1884?focusedWorklogId=493007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493007
 ]

ASF GitHub Bot logged work on ARTEMIS-1884:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Sep/20 15:17
            Start Date: 30/Sep/20 15:17
    Worklog Time Spent: 10m 
      Work Description: gtully commented on pull request #3281:
URL: https://github.com/apache/activemq-artemis/pull/3281#issuecomment-701458356


   this looks nice but it seem too many hoops to go through to have a plugin 
implement a filter and a very specific new plugin type. A generic filter may be 
more generally applicable. canAccept behaving like filter.match and gating 
delivery.
   
   maybe the existing broker plugin can have a new: 
    - boolean canAccept(ServerConsumer, MessageReference)
   
   and with the new getSubject accessor that can implement authorization. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 493007)
    Time Spent: 20m  (was: 10m)

> ActiveMQ5-like message-level authorization
> ------------------------------------------
>
>                 Key: ARTEMIS-1884
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1884
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Johan Stenberg
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In ActiveMQ 5 we have 
> [MessageAuthorizationPolicy|https://activemq.apache.org/maven/apidocs/org/apache/activemq/security/MessageAuthorizationPolicy.html].
>  We would need a similar feature in Artemis to being able to migrate to it.
> In Artemis exists the 
> [ActiveMQServerPlugin#beforeDeliver|https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerPlugin.java#L502]
>  callback method were we probably could prevent message delivery by throwing 
> an exception but using exceptions for flow control feels like a very wrong 
> thing to do here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to