[
https://issues.apache.org/jira/browse/ARTEMIS-1884?focusedWorklogId=493292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493292
]
ASF GitHub Bot logged work on ARTEMIS-1884:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/20 05:39
Start Date: 01/Oct/20 05:39
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3281:
URL: https://github.com/apache/activemq-artemis/pull/3281#discussion_r497994464
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -2444,6 +2446,25 @@ public void callBrokerMessagePlugins(final
ActiveMQPluginRunnable<ActiveMQServer
callBrokerPlugins(getBrokerMessagePlugins(), pluginRun);
}
+ @Override
+ public boolean callBrokerMessagePluginsCanAccept(ServerConsumer
serverConsumer, MessageReference messageReference) throws ActiveMQException {
+ for (ActiveMQServerMessagePlugin plugin : getBrokerMessagePlugins()) {
Review comment:
Default return should surely be false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493292)
Time Spent: 0.5h (was: 20m)
> ActiveMQ5-like message-level authorization
> ------------------------------------------
>
> Key: ARTEMIS-1884
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1884
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Reporter: Johan Stenberg
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In ActiveMQ 5 we have
> [MessageAuthorizationPolicy|https://activemq.apache.org/maven/apidocs/org/apache/activemq/security/MessageAuthorizationPolicy.html].
> We would need a similar feature in Artemis to being able to migrate to it.
> In Artemis exists the
> [ActiveMQServerPlugin#beforeDeliver|https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerPlugin.java#L502]
> callback method were we probably could prevent message delivery by throwing
> an exception but using exceptions for flow control feels like a very wrong
> thing to do here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
