[
https://issues.apache.org/jira/browse/ARTEMIS-2937?focusedWorklogId=506138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506138
]
ASF GitHub Bot logged work on ARTEMIS-2937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 09:51
Start Date: 29/Oct/20 09:51
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3316:
URL: https://github.com/apache/activemq-artemis/pull/3316#discussion_r514131674
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LinkedListImpl.java
##########
@@ -72,9 +115,43 @@ public void addHead(E e) {
node.next.prev = node;
}
+ itemAdded(node, e);
+
size++;
}
+ @Override
+ public E removeWithID(long id) {
+ if (nodeMap == null) {
+ return null;
+ }
+
+ Node<E> node = nodeMap.get(id);
+ if (node == null) {
+ return null;
+ }
+
+ if (node.prev != null) {
+ removeAfter(node.prev);
+ }
Review comment:
Its more confusion and concern that it has modified the 'side area' map
at this point but could return without removing anything from the the actual
main list structure. If this is something to be careful about it seems more
like it should be throwing an IllegalStateException or somthing rather than
silently skipping, since the list must be broken for the check to have any
effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 506138)
Time Spent: 32.5h (was: 32h 20m)
> AMQP Server Connectivity
> ------------------------
>
> Key: ARTEMIS-2937
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2937
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 32.5h
> Remaining Estimate: 0h
>
> This feature adds server side connectivity.
>
> It is possible to link two brokers directly using AMQP with this feature, and
> have a Queue transferring messages to another broker directly.
>
> For this we would have options called <sender and <receiver
>
>
> it would also be possible to use qpid-dispatch as an intermediary between
> clients and the brokers (or eventually between brokers), on that case the
> option will be <peer
>
> it would also be possible to use <mirror with a few option to replicate data
> between two brokers, bringing the possibility of using it for Disaster &
> Recovery and Failover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
