[
https://issues.apache.org/jira/browse/ARTEMIS-2937?focusedWorklogId=506148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506148
]
ASF GitHub Bot logged work on ARTEMIS-2937:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/20 10:19
Start Date: 29/Oct/20 10:19
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3316:
URL: https://github.com/apache/activemq-artemis/pull/3316#discussion_r514149152
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -129,7 +156,7 @@ public AMQPConnectionContext(ProtonProtocolManager
protocolManager,
} else {
nettyExecutor = new
ExecutorNettyAdapter(protocolManager.getServer().getExecutorFactory().getExecutor());
}
- this.handler = new ProtonHandler(nettyExecutor,
protocolManager.getServer().getExecutorFactory().getExecutor(),
isIncomingConnection);
+ this.handler = new ProtonHandler(nettyExecutor,
protocolManager.getServer().getExecutorFactory().getExecutor(),
isIncomingConnection && saslClientFactory == null);
Review comment:
The bit im talking about is part of your change, its the diff being
commented on. The change makes the value passed for ''isServer' also dependent
on whether or not saslClientFactory is null or not. The usage of these bits it
in the overall changes mean it can be both null and non-null values, for
outgoing 'client' connections. I dont see why the value passed for 'isServer'
would change depending on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 506148)
Time Spent: 32h 40m (was: 32.5h)
> AMQP Server Connectivity
> ------------------------
>
> Key: ARTEMIS-2937
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2937
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 32h 40m
> Remaining Estimate: 0h
>
> This feature adds server side connectivity.
>
> It is possible to link two brokers directly using AMQP with this feature, and
> have a Queue transferring messages to another broker directly.
>
> For this we would have options called <sender and <receiver
>
>
> it would also be possible to use qpid-dispatch as an intermediary between
> clients and the brokers (or eventually between brokers), on that case the
> option will be <peer
>
> it would also be possible to use <mirror with a few option to replicate data
> between two brokers, bringing the possibility of using it for Disaster &
> Recovery and Failover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
