[
https://issues.apache.org/jira/browse/ARTEMIS-2996?focusedWorklogId=512593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512593
]
ASF GitHub Bot logged work on ARTEMIS-2996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/20 21:12
Start Date: 16/Nov/20 21:12
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3343:
URL: https://github.com/apache/activemq-artemis/pull/3343#discussion_r524586334
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -67,17 +69,23 @@ public boolean containsWildCard() {
}
@Override
- public List<Address> getLinkedAddresses() {
- return linkedAddresses;
+ public Collection<Address> getLinkedAddresses() {
+ return linkedAddresses == null ? Collections.emptySet() :
linkedAddresses;
Review comment:
There are a bunch of places where getLinkedAddresses are iterated over,
and the collection is not thread safe. We need to double check those are
covered by an external sync such that we don't get concurrent mod exceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 512593)
Time Spent: 8h 10m (was: 8h)
> Provide JMH Benchmarks for Artemis
> ----------------------------------
>
> Key: ARTEMIS-2996
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2996
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Tests
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> In order to reliably measure performance of many Artemis component would be
> welcome to implement some https://github.com/openjdk/jmh benchmarks to be
> used for development purposes ie not part of the release
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
