[
https://issues.apache.org/jira/browse/ARTEMIS-2996?focusedWorklogId=512732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512732
]
ASF GitHub Bot logged work on ARTEMIS-2996:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/20 05:06
Start Date: 17/Nov/20 05:06
Worklog Time Spent: 10m
Work Description: franz1981 commented on a change in pull request #3343:
URL: https://github.com/apache/activemq-artemis/pull/3343#discussion_r524886715
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -67,17 +69,23 @@ public boolean containsWildCard() {
}
@Override
- public List<Address> getLinkedAddresses() {
- return linkedAddresses;
+ public Collection<Address> getLinkedAddresses() {
+ return linkedAddresses == null ? Collections.emptySet() :
linkedAddresses;
Review comment:
I see that and I'm a bit concern about it, but I don't think that the
initialization will make any difference here...
There is a synchronization problem here. period...
It's weird we've never had issues on this, so I'm going to write a test and
check if I can break it. If not, putting a synchronize will just kill
performance and the same if we copy the whole linked addresses list in and out
from a synchronization block (or we use a copy on write data structure too, but
on addBinding/removeBinding side)....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 512732)
Time Spent: 9h 50m (was: 9h 40m)
> Provide JMH Benchmarks for Artemis
> ----------------------------------
>
> Key: ARTEMIS-2996
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2996
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Tests
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> In order to reliably measure performance of many Artemis component would be
> welcome to implement some https://github.com/openjdk/jmh benchmarks to be
> used for development purposes ie not part of the release
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
