[
https://issues.apache.org/jira/browse/ARTEMIS-2990?focusedWorklogId=514711&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514711
]
ASF GitHub Bot logged work on ARTEMIS-2990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/20 16:50
Start Date: 20/Nov/20 16:50
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3352:
URL: https://github.com/apache/activemq-artemis/pull/3352#discussion_r527809669
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -84,6 +84,7 @@ public void addLinkedAddress(final Address address) {
if (linkedAddresses == null) {
linkedAddresses = PlatformDependent.hasUnsafe() ? new
NonBlockingHashSet<>() : new ConcurrentHashSet<>();
}
+ assert !linkedAddresses.contains(address);
Review comment:
If you want to validate it, as noted and as per general collections
behaviour its normal to return true false if a change occured not error with an
assert. I disagree with the original comment you reference advising you to add
an assert.
Raising runtime exceptions like assert does is not a great pattern. If we
really want to throw an exception rather than return true false. Make a
declared exception and throw that, then calling code will then at least expect
it and handle it. (I still prefer using a boolean return here it follows the
normal pattern used by collections)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 514711)
Time Spent: 6h 10m (was: 6h)
> optimise performance of wildcard address manager
> ------------------------------------------------
>
> Key: ARTEMIS-2990
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2990
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.16.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> A scenario test with lots of short lived concurrent wildcard subs
> demonstrates some bottlenecks in the wildcard address and binding manager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
