[
https://issues.apache.org/jira/browse/ARTEMIS-2990?focusedWorklogId=514714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514714
]
ASF GitHub Bot logged work on ARTEMIS-2990:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/20 17:01
Start Date: 20/Nov/20 17:01
Worklog Time Spent: 10m
Work Description: franz1981 commented on a change in pull request #3352:
URL: https://github.com/apache/activemq-artemis/pull/3352#discussion_r527830189
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -84,6 +84,7 @@ public void addLinkedAddress(final Address address) {
if (linkedAddresses == null) {
linkedAddresses = PlatformDependent.hasUnsafe() ? new
NonBlockingHashSet<>() : new ConcurrentHashSet<>();
}
+ assert !linkedAddresses.contains(address);
Review comment:
In this case what could be the proper action in case we see the linked
address to be added twice? A log? An exception?
I suppose both are poor to capture a performance need (more then a
correctness thing). I am open to proposals here but I am not sure asserts are
not (equally) good if the motivation behind their usage is to guide specific
invariant to be checked with no cost at runtime, on tests, especially for
performance reasons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 514714)
Time Spent: 6h 40m (was: 6.5h)
> optimise performance of wildcard address manager
> ------------------------------------------------
>
> Key: ARTEMIS-2990
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2990
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.16.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> A scenario test with lots of short lived concurrent wildcard subs
> demonstrates some bottlenecks in the wildcard address and binding manager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
